Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1296

Fix permission and Update README for vagrant-puppet recipe

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: vm
    • Labels:
      None

      Description

      Some minor updates to the VM provisioning (make the shell script perms executable) and README doc.

        Activity

        Hide
        jayunit100 jay vyas added a comment -

        Here's a quick patch that will fix perms on this file w/ a few quick updates to the README.md .

        Show
        jayunit100 jay vyas added a comment - Here's a quick patch that will fix perms on this file w/ a few quick updates to the README.md .
        Hide
        jayunit100 jay vyas added a comment -

        hi bigtop, can i get a quick +1 on this ? its just a README update and chmod for the vagrant script.

        After that i will exersize my new BigTop apache superpowers to commit the patch MYSELF

        Show
        jayunit100 jay vyas added a comment - hi bigtop, can i get a quick +1 on this ? its just a README update and chmod for the vagrant script. After that i will exersize my new BigTop apache superpowers to commit the patch MYSELF
        Hide
        gujilangzi Wenwu Peng added a comment -

        LGTM +1, Thanks jay

        Show
        gujilangzi Wenwu Peng added a comment - LGTM +1, Thanks jay
        Hide
        jayunit100 jay vyas added a comment -

        okay done ! thanks wenwupeng !

        Show
        jayunit100 jay vyas added a comment - okay done ! thanks wenwupeng !
        Hide
        cos Konstantin Boudnik added a comment -

        Do we need to use github's code notations e.g. ``` in the readme?

        Show
        cos Konstantin Boudnik added a comment - Do we need to use github's code notations e.g. ``` in the readme?
        Hide
        jayunit100 jay vyas added a comment -

        Its the standard readme.md syntax... Looks good to me ?
        https://github.com/apache/bigtop/tree/master/bigtop-deploy/vm/vagrant-puppet

        Maybe your suggesting that we should do README syntax, rather than README.md syntax?

        Show
        jayunit100 jay vyas added a comment - Its the standard readme.md syntax... Looks good to me ? https://github.com/apache/bigtop/tree/master/bigtop-deploy/vm/vagrant-puppet Maybe your suggesting that we should do README syntax, rather than README.md syntax?
        Hide
        cos Konstantin Boudnik added a comment -

        Nah, never mind - my .md foo is weak

        Show
        cos Konstantin Boudnik added a comment - Nah, never mind - my .md foo is weak

          People

          • Assignee:
            Unassigned
            Reporter:
            jayunit100 jay vyas
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development