Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1191

master pom.xml file formatting is out of whack

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.8.0
    • Component/s: general
    • Labels:
      None

      Description

      As the result of BIGTOP-1157 the formatting of master pom.xml

      This JIRA is to track fixing.

      1. BIGTOP-1191.patch
        30 kB
        Konstantin Boudnik

        Activity

        Hide
        plinnell Peter Linnell added a comment -

        +1 The old formatting wants to make me scratch my eyes out

        Show
        plinnell Peter Linnell added a comment - +1 The old formatting wants to make me scratch my eyes out
        Hide
        bmahe Bruno Mahé added a comment -

        +1.
        Sorry! I didn't know tabs had such effects on you

        Although tabs have their merit.

        Show
        bmahe Bruno Mahé added a comment - +1. Sorry! I didn't know tabs had such effects on you Although tabs have their merit.
        Hide
        jayunit100 jay vyas added a comment -
        • What is the "bug" here .... tabs vs spaces ? Just clarifying.
        • is bigtop not going to use tabs anymore?

        just checking..

        Show
        jayunit100 jay vyas added a comment - What is the "bug" here .... tabs vs spaces ? Just clarifying. is bigtop not going to use tabs anymore? just checking..
        Hide
        mackrorysd Sean Mackrory added a comment - - edited

        is bigtop not going to use tabs anymore?

        That would be a difficult practice, since Makefiles and some Debian files require the use of tabs Especially with Bigtop, I like to do this with vim, so I can see the difference and just be consistent with whatever file I'm editing. Otherwise the error message you get when building is not very obvious:

        set listchars=tab:__,trail:_,extends:>,precedes:<
        Show
        mackrorysd Sean Mackrory added a comment - - edited is bigtop not going to use tabs anymore? That would be a difficult practice, since Makefiles and some Debian files require the use of tabs Especially with Bigtop, I like to do this with vim, so I can see the difference and just be consistent with whatever file I'm editing. Otherwise the error message you get when building is not very obvious: set listchars=tab:__,trail:_, extends :>,precedes:<
        Hide
        cos Konstantin Boudnik added a comment -

        Guys, pom.xml and other Java/Groovy files in Bigtop never been using tabs: we are sticking to Hadoop code guidelines. As the matter of fact when Bruno did the documentation fix he started using tabs in this pom.xml for the first time, really.

        Tabs can be used where they are appropriate - e.g. Makefiles, etc. - I don't see any problems with it.

        Show
        cos Konstantin Boudnik added a comment - Guys, pom.xml and other Java/Groovy files in Bigtop never been using tabs: we are sticking to Hadoop code guidelines. As the matter of fact when Bruno did the documentation fix he started using tabs in this pom.xml for the first time, really. Tabs can be used where they are appropriate - e.g. Makefiles, etc. - I don't see any problems with it.
        Hide
        cos Konstantin Boudnik added a comment -

        Committed and pushed to master

        Show
        cos Konstantin Boudnik added a comment - Committed and pushed to master
        Hide
        apurtell Andrew Purtell added a comment -

        Issues like this tend to be settled towards who has the strongest opinion. Is that Cos? +1 for this patch on those grounds.

        Show
        apurtell Andrew Purtell added a comment - Issues like this tend to be settled towards who has the strongest opinion. Is that Cos? +1 for this patch on those grounds.
        Hide
        cos Konstantin Boudnik added a comment -

        I don't think this is the matter of the strongest opinion, but rather the way the Java related part of the project has been formatted. If we need to change to formatting - let's do as community sees fit. But let's do it as a separate effort rather than mixing it with the fixes and new features.

        Show
        cos Konstantin Boudnik added a comment - I don't think this is the matter of the strongest opinion, but rather the way the Java related part of the project has been formatted. If we need to change to formatting - let's do as community sees fit. But let's do it as a separate effort rather than mixing it with the fixes and new features.

          People

          • Assignee:
            cos Konstantin Boudnik
            Reporter:
            cos Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development