Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Perhaps, it might an independent (optional) module (instead of simply adding tests in hadoop/hdfs module), because one could have no HttpFs installed and running on his/her cluster.

        Activity

        Hide
        kawaa Adam Kawa added a comment - - edited

        In my patch, I assume that HttpFs proxy is exported via HTTPFS_PROXY e.g.
        export HTTPFS_PROXY=hostname:port

        I created an independent (optional) module (instead of simply adding tests in hadoop/hdfs module), because one could have no HttpFs installed and running on his/her cluster.

        Show
        kawaa Adam Kawa added a comment - - edited In my patch, I assume that HttpFs proxy is exported via HTTPFS_PROXY e.g. export HTTPFS_PROXY=hostname:port I created an independent (optional) module (instead of simply adding tests in hadoop/hdfs module), because one could have no HttpFs installed and running on his/her cluster.
        Hide
        sunjun Jun Sun added a comment -

        Patch worked fine.
        Adam, should we verify the directories or files after the http request?

        Show
        sunjun Jun Sun added a comment - Patch worked fine. Adam, should we verify the directories or files after the http request?
        Hide
        rvs Roman Shaposhnik added a comment -

        +1 and committed! Thanks to Adam Kawa for the patch (and being patient!) and to [~junsun] for review!

        Show
        rvs Roman Shaposhnik added a comment - +1 and committed! Thanks to Adam Kawa for the patch (and being patient!) and to [~junsun] for review!
        Hide
        kawaa Adam Kawa added a comment -

        [~junsun] thanks for a review. I implemented more smoke tests, so I will send then to JIRA and I will include the one that verify the directories/files after the http request, as you recommend.
        Roman Shaposhnik thanks for merging it! It is my first patch to Bigtop, so I am excited!

        Show
        kawaa Adam Kawa added a comment - [~junsun] thanks for a review. I implemented more smoke tests, so I will send then to JIRA and I will include the one that verify the directories/files after the http request, as you recommend. Roman Shaposhnik thanks for merging it! It is my first patch to Bigtop, so I am excited!
        Hide
        jaoki jun aoki added a comment -

        There are 2 Shell instances defined

        TestHttpFs.groovy
         49     private static Shell shHDFS = new Shell("/bin/bash", USERNAME);                                            
         50     private static Shell sh = new Shell("/bin/bash");
        
        TestHttpFs.groovy
        110         sh.exec("curl -i -X DELETE '$HTTPFS_PREFIX$testHttpFsFolder?user.name=$USERNAME&op=DELETE'");
        111         assertTrue("curl command to delete a dir failed", shHDFS.getRet() == 0);
        
        

        and curl are called by sh but ret code is got by shHDFS instance.
        Are they discrepancy?

        Show
        jaoki jun aoki added a comment - There are 2 Shell instances defined TestHttpFs.groovy 49 private static Shell shHDFS = new Shell( "/bin/bash" , USERNAME); 50 private static Shell sh = new Shell( "/bin/bash" ); TestHttpFs.groovy 110 sh.exec( "curl -i -X DELETE '$HTTPFS_PREFIX$testHttpFsFolder?user.name=$USERNAME&op=DELETE'" ); 111 assertTrue( "curl command to delete a dir failed" , shHDFS.getRet() == 0); and curl are called by sh but ret code is got by shHDFS instance. Are they discrepancy?
        Hide
        kawaa Adam Kawa added a comment -

        jun aoki this is a bug. Should I send a new patch here, or create a new ticket?

        Show
        kawaa Adam Kawa added a comment - jun aoki this is a bug. Should I send a new patch here, or create a new ticket?
        Hide
        jaoki jun aoki added a comment -

        Adam Kawa I'm glad that I can review bigtop code. I'm new to bigtop too . I let Roman Shaposhnik decide.

        Show
        jaoki jun aoki added a comment - Adam Kawa I'm glad that I can review bigtop code. I'm new to bigtop too . I let Roman Shaposhnik decide.
        Hide
        rvs Roman Shaposhnik added a comment -

        Good catch jun aoki! Much appreciated! Adam Kawa please open up a new ticket and attach a patch

        Show
        rvs Roman Shaposhnik added a comment - Good catch jun aoki ! Much appreciated! Adam Kawa please open up a new ticket and attach a patch
        Hide
        kawaa Adam Kawa added a comment -

        New ticket is here BIGTOP-1246. I will send a patch soon.

        Show
        kawaa Adam Kawa added a comment - New ticket is here BIGTOP-1246 . I will send a patch soon.

          People

          • Assignee:
            rvs Roman Shaposhnik
            Reporter:
            kawaa Adam Kawa
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development