Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.1.0
    • Component/s: general
    • Labels:
      None

      Description

      Hama is being excluded since 0.4 version. Since latest Hama version is compatible with Hadoop 2, we can start to integrate.

        Activity

        Hide
        udanax Edward J. Yoon added a comment -

        attach my patch.

        Show
        udanax Edward J. Yoon added a comment - attach my patch.
        Hide
        plinnell Peter Linnell added a comment -

        I'll look at the integration as soon as we get 0.7.0 released. Thanks for the patch.

        Show
        plinnell Peter Linnell added a comment - I'll look at the integration as soon as we get 0.7.0 released. Thanks for the patch.
        Hide
        cos Konstantin Boudnik added a comment -

        any update on this one? Is it still in the scope of 0.8.0?

        Show
        cos Konstantin Boudnik added a comment - any update on this one? Is it still in the scope of 0.8.0?
        Hide
        rvs Roman Shaposhnik added a comment -

        I'd say – lets push it to backlog, since I haven't much movement on that ticket.

        Show
        rvs Roman Shaposhnik added a comment - I'd say – lets push it to backlog, since I haven't much movement on that ticket.
        Hide
        udanax Edward J. Yoon added a comment -

        I need to investigate more. Once my work is done, I'll update the target version. Thanks.

        Show
        udanax Edward J. Yoon added a comment - I need to investigate more. Once my work is done, I'll update the target version. Thanks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eoriented opened a pull request:

        https://github.com/apache/bigtop/pull/24

        BIGTOP-1126. Add Hama to Bigtop

        Hi,
        I have modified the patch file to run latest Hama version on bigtop.
        Also, I already have tested deb file on Ubuntu 14.04 and rpm file on CentOS 7.
        I make sure that Hama was working correctly in local mode.

        Please review it.
        Thanks.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eoriented/bigtop hama

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/24.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #24


        commit 39db6111faa37e6904d5d526c4ec26ffdab95fce
        Author: Minho Kim <minwise.kim@samsung.com>
        Date: 2015-07-31T02:16:05Z

        BIGTOP-1126. Add Hama to Bigtop


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eoriented opened a pull request: https://github.com/apache/bigtop/pull/24 BIGTOP-1126 . Add Hama to Bigtop Hi, I have modified the patch file to run latest Hama version on bigtop. Also, I already have tested deb file on Ubuntu 14.04 and rpm file on CentOS 7. I make sure that Hama was working correctly in local mode. Please review it. Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eoriented/bigtop hama Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit 39db6111faa37e6904d5d526c4ec26ffdab95fce Author: Minho Kim <minwise.kim@samsung.com> Date: 2015-07-31T02:16:05Z BIGTOP-1126 . Add Hama to Bigtop
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-126566044

        Thanks for your PR @eoriented but I'm afraid that you've missed some related files: packaging, smokes and etc. Please make sure the current PR has all your local changes. IMO, it looks like the PR has only changes on bigtop BOM(bigtop.mk)

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-126566044 Thanks for your PR @eoriented but I'm afraid that you've missed some related files: packaging, smokes and etc. Please make sure the current PR has all your local changes. IMO, it looks like the PR has only changes on bigtop BOM(bigtop.mk)
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-126566723

        Oops,
        I'm sorry that I forget committing packaging files.
        I'll commit now.

        Thanks @youngwookim

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-126566723 Oops, I'm sorry that I forget committing packaging files. I'll commit now. Thanks @youngwookim
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jayunit100 commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-126661034

        Why are there two commits ?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jayunit100 commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-126661034 Why are there two commits ?
        Hide
        jayunit100 jay vyas added a comment -

        Thanks for this... also... Which patch ? the github one? Or the jira one.

        Show
        jayunit100 jay vyas added a comment - Thanks for this... also... Which patch ? the github one? Or the jira one.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-126854536

        I changed one commit.

        Thanks.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-126854536 I changed one commit. Thanks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on a diff in the pull request:

        https://github.com/apache/bigtop/pull/24#discussion_r36049839

        — Diff: bigtop-packages/src/common/hama/do-component-build —
        @@ -0,0 +1,19 @@
        +#!/bin/sh
        +# Licensed to the Apache Software Foundation (ASF) under one or more
        +# contributor license agreements. See the NOTICE file distributed with
        +# this work for additional information regarding copyright ownership.
        +# The ASF licenses this file to You under the Apache License, Version 2.0
        +# (the "License"); you may not use this file except in compliance with
        +# the License. You may obtain a copy of the License at
        +#
        +# http://www.apache.org/licenses/LICENSE-2.0
        +#
        +# Unless required by applicable law or agreed to in writing, software
        +# distributed under the License is distributed on an "AS IS" BASIS,
        +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        +# See the License for the specific language governing permissions and
        +# limitations under the License.
        +
        +set -ex
        +
        +mvn clean install -DskipTests "$@"
        — End diff –

        IMO, It would be nice to have appropriate dependency here:

            -mvn clean install -DskipTests "$@"
            +. `dirname ${0}`/bigtop.bom
            +
            +mvn -Phadoop2 -Dhadoop.version=$HADOOP_VERSION -Dzookeeper.version=$ZOOKEEPER_VERSION clean install -DskipTests "$@"
            
        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on a diff in the pull request: https://github.com/apache/bigtop/pull/24#discussion_r36049839 — Diff: bigtop-packages/src/common/hama/do-component-build — @@ -0,0 +1,19 @@ +#!/bin/sh +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -ex + +mvn clean install -DskipTests "$@" — End diff – IMO, It would be nice to have appropriate dependency here: -mvn clean install -DskipTests "$@" +. `dirname ${0}`/bigtop.bom + +mvn -Phadoop2 -Dhadoop.version=$HADOOP_VERSION -Dzookeeper.version=$ZOOKEEPER_VERSION clean install -DskipTests "$@"
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on a diff in the pull request:

        https://github.com/apache/bigtop/pull/24#discussion_r36049924

        — Diff: bigtop-packages/src/deb/hama/control —
        @@ -0,0 +1,67 @@
        +# Licensed to the Apache Software Foundation (ASF) under one or more
        +# contributor license agreements. See the NOTICE file distributed with
        +# this work for additional information regarding copyright ownership.
        +# The ASF licenses this file to You under the Apache License, Version 2.0
        +# (the "License"); you may not use this file except in compliance with
        +# the License. You may obtain a copy of the License at
        +#
        +# http://www.apache.org/licenses/LICENSE-2.0
        +#
        +# Unless required by applicable law or agreed to in writing, software
        +# distributed under the License is distributed on an "AS IS" BASIS,
        +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        +# See the License for the specific language governing permissions and
        +# limitations under the License.
        +
        +Source: hama
        +Section: misc
        +Priority: extra
        +Maintainer: BigTop
        +Build-Depends: debhelper (>= 6)
        — End diff –

        Please update compat to 9 [1]

        [1] https://cwiki.apache.org/confluence/display/BIGTOP/Bigtop+Packaging

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on a diff in the pull request: https://github.com/apache/bigtop/pull/24#discussion_r36049924 — Diff: bigtop-packages/src/deb/hama/control — @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +Source: hama +Section: misc +Priority: extra +Maintainer: BigTop +Build-Depends: debhelper (>= 6) — End diff – Please update compat to 9 [1] [1] https://cwiki.apache.org/confluence/display/BIGTOP/Bigtop+Packaging
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on a diff in the pull request:

        https://github.com/apache/bigtop/pull/24#discussion_r36049933

        — Diff: bigtop-packages/src/deb/hama/control —
        @@ -0,0 +1,67 @@
        +# Licensed to the Apache Software Foundation (ASF) under one or more
        +# contributor license agreements. See the NOTICE file distributed with
        +# this work for additional information regarding copyright ownership.
        +# The ASF licenses this file to You under the Apache License, Version 2.0
        +# (the "License"); you may not use this file except in compliance with
        +# the License. You may obtain a copy of the License at
        +#
        +# http://www.apache.org/licenses/LICENSE-2.0
        +#
        +# Unless required by applicable law or agreed to in writing, software
        +# distributed under the License is distributed on an "AS IS" BASIS,
        +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        +# See the License for the specific language governing permissions and
        +# limitations under the License.
        +
        +Source: hama
        +Section: misc
        +Priority: extra
        +Maintainer: BigTop
        +Build-Depends: debhelper (>= 6)
        +Standards-Version: 3.8.0
        — End diff –

        Please Standards-Version to 3.9.4 [1]

        [1] https://cwiki.apache.org/confluence/display/BIGTOP/Bigtop+Packaging

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on a diff in the pull request: https://github.com/apache/bigtop/pull/24#discussion_r36049933 — Diff: bigtop-packages/src/deb/hama/control — @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +Source: hama +Section: misc +Priority: extra +Maintainer: BigTop +Build-Depends: debhelper (>= 6) +Standards-Version: 3.8.0 — End diff – Please Standards-Version to 3.9.4 [1] [1] https://cwiki.apache.org/confluence/display/BIGTOP/Bigtop+Packaging
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-127085503

        @eoriented, Overall looks good to me. Left a few comments. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-127085503 @eoriented, Overall looks good to me. Left a few comments. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on a diff in the pull request:

        https://github.com/apache/bigtop/pull/24#discussion_r36061325

        — Diff: bigtop-packages/src/deb/hama/compat —
        @@ -0,0 +1 @@
        +6
        — End diff –

        Forgot to mention, please update compat and debhelper to 9. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on a diff in the pull request: https://github.com/apache/bigtop/pull/24#discussion_r36061325 — Diff: bigtop-packages/src/deb/hama/compat — @@ -0,0 +1 @@ +6 — End diff – Forgot to mention, please update compat and debhelper to 9. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-128005486

        Thank you for your opinion.

        I modified code, which reflects your comment.
        Please check it and let me know if more modification.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-128005486 Thank you for your opinion. I modified code, which reflects your comment. Please check it and let me know if more modification.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user edwardyoon commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-128186607

        +1 lgtm.

        Show
        githubbot ASF GitHub Bot added a comment - Github user edwardyoon commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-128186607 +1 lgtm.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-128229019

        Thanks @eoriented, Almost there!

        A few things:

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-128229019 Thanks @eoriented, Almost there! A few things: Please add a following line to the spec file ``` Source6: bigtop.bom ``` Please add an entry for Hama at MAINTAINERS, https://github.com/apache/bigtop/blob/master/MAINTAINERS.txt For now, an entry for MAINTAINERS.txt is not mandatory but I believe that it would be good to have maintainers to prevent the orphaned component and to resolve issues from individual component quickly. Current assignee for https://issues.apache.org/jira/browse/BIGTOP-1126 is @edwardyoon This should be changed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user edwardyoon commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-128231569

        @eoriented Please add your name and my asf id: edwardyoon

        Show
        githubbot ASF GitHub Bot added a comment - Github user edwardyoon commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-128231569 @eoriented Please add your name and my asf id: edwardyoon
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129699287

        Thanks @youngwookim ,
        I added my name and edward name in https://github.com/apache/bigtop/blob/master/MAINTAINERS.txt.

        However I cannot change assignee to me for BIGTOP-1126https://issues.apache.org/jira/browse/BIGTOP-1126. I have no permit for Bigtop's Jira.
        How can I get authority changing assignee in this issue?
        Please check code modified and let me know above question.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129699287 Thanks @youngwookim , I added my name and edward name in https://github.com/apache/bigtop/blob/master/MAINTAINERS.txt . However I cannot change assignee to me for BIGTOP-1126 https://issues.apache.org/jira/browse/BIGTOP-1126 . I have no permit for Bigtop's Jira. How can I get authority changing assignee in this issue? Please check code modified and let me know above question.
        Hide
        warwithin YoungWoo Kim added a comment -

        Konstantin Boudnik, Please assign this JIRA to Minho Kim. Thanks!

        Show
        warwithin YoungWoo Kim added a comment - Konstantin Boudnik , Please assign this JIRA to Minho Kim . Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129703865

        Thank you, @eoriented ! I've left a message to our moderator. Will be changed the assignee field on JIRA.

        In the meanwhile, I'll test your patch.

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129703865 Thank you, @eoriented ! I've left a message to our moderator. Will be changed the assignee field on JIRA. In the meanwhile, I'll test your patch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129711957

        @eoriented I got a merge conflict from 'MAINTAINERS.txt' Please rebase your changes to master branch. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129711957 @eoriented I got a merge conflict from 'MAINTAINERS.txt' Please rebase your changes to master branch. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129723106

        @youngwookim I'm sorry that I'm not used to using git.
        Is it right? or If it's wrong, please let me know how to do that.

        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129723106 @youngwookim I'm sorry that I'm not used to using git. Is it right? or If it's wrong, please let me know how to do that. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129729375

        OK. You should 'rebase' your working branch to ASF master before sending a PR because your commit is far behind current master branch. Sometimes there are merge conflicts while someone is trying to merge the patch. This is a simple workflow for 'git rebase':
        ```
        git checkout master
        git pull asf master
        git checkout YOUR-WORKING-BRANCH
        git rebase -i asf/master
        git push origin YOUR-WORKING-BRANCH
        ```
        'asf' is a name for ASF git remote or github's bigtop mirror!

        For more details, just googling 'git rebase'!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129729375 OK. You should 'rebase' your working branch to ASF master before sending a PR because your commit is far behind current master branch. Sometimes there are merge conflicts while someone is trying to merge the patch. This is a simple workflow for 'git rebase': ``` git checkout master git pull asf master git checkout YOUR-WORKING-BRANCH git rebase -i asf/master git push origin YOUR-WORKING-BRANCH ``` 'asf' is a name for ASF git remote or github's bigtop mirror! For more details, just googling 'git rebase'!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129737677

        @eoriented Please hold off the work that I've mentioned. It looks like a bug on Github while github is generating the diff or patch. Will investigate it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129737677 @eoriented Please hold off the work that I've mentioned. It looks like a bug on Github while github is generating the diff or patch. Will investigate it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129738666

        @youngwookim Ok. I'll wait it.
        Thank you for a lucid explanation.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129738666 @youngwookim Ok. I'll wait it. Thank you for a lucid explanation.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129745248

        Got it, It's not a bug, Github's 'patch' is not same as 'diff'. I did not know that! I think fixing the commit history is not easy at this point so I would encourage you to make new PR or patch from the current diff – https://github.com/apache/bigtop/pull/24.diff

        First, please make a fresh branch and then apply your changes into the branch with a same commit message. like below:
        1. Download current diff from github:
        ```
        cd /tmp/
        wget https://github.com/apache/bigtop/pull/24.diff
        ```
        2. Apply the diff (again):
        ```
        git pull asf master
        git checkout -b BIGTOP-1126
        git apply /tmp/24.diff
        git add -A
        git commit -m 'BIGTOP-1126. ...'
        git push origin BIGTOP-1126
        ```
        And then, please re-send a PR. Maybe... there are better ways but don't know exactly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129745248 Got it, It's not a bug, Github's 'patch' is not same as 'diff'. I did not know that! I think fixing the commit history is not easy at this point so I would encourage you to make new PR or patch from the current diff – https://github.com/apache/bigtop/pull/24.diff First, please make a fresh branch and then apply your changes into the branch with a same commit message. like below: 1. Download current diff from github: ``` cd /tmp/ wget https://github.com/apache/bigtop/pull/24.diff ``` 2. Apply the diff (again): ``` git pull asf master git checkout -b BIGTOP-1126 git apply /tmp/24.diff git add -A git commit -m ' BIGTOP-1126 . ...' git push origin BIGTOP-1126 ``` And then, please re-send a PR. Maybe... there are better ways but don't know exactly.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/24#issuecomment-129752689

        @eoriented Please keep in mind you should have one commit and it's rebased to current master! Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/24#issuecomment-129752689 @eoriented Please keep in mind you should have one commit and it's rebased to current master! Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user eoriented opened a pull request:

        https://github.com/apache/bigtop/pull/26

        BIGTOP-1126. Add Hama to Bigtop

        Hi @youngwookim

        I resend a PR as directed because a conflict occurs during the merge.
        Please check this PR. And Do I close another PR on the following link?
        https://github.com/apache/bigtop/pull/24

        Please let me know about that.

        Thanks.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/eoriented/bigtop BIGTOP-1126

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/bigtop/pull/26.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #26


        commit e6126ec28d98b2189fd791193ee0d19f40bf068a
        Author: Minho Kim <minwise.kim@samsung.com>
        Date: 2015-08-12T00:55:09Z

        BIGTOP-1126. Add Hama to Bigtop


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user eoriented opened a pull request: https://github.com/apache/bigtop/pull/26 BIGTOP-1126 . Add Hama to Bigtop Hi @youngwookim I resend a PR as directed because a conflict occurs during the merge. Please check this PR. And Do I close another PR on the following link? https://github.com/apache/bigtop/pull/24 Please let me know about that. Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eoriented/bigtop BIGTOP-1126 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/bigtop/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit e6126ec28d98b2189fd791193ee0d19f40bf068a Author: Minho Kim <minwise.kim@samsung.com> Date: 2015-08-12T00:55:09Z BIGTOP-1126 . Add Hama to Bigtop
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/26#issuecomment-130134606

        @eoriented bigtop.mk file is missing!? please take a look, Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/26#issuecomment-130134606 @eoriented bigtop.mk file is missing!? please take a look, Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/26#issuecomment-130176988

        @youngwookim I add bigtop.mk file in this branch.
        Please check it!
        And Would I close PR which is #24?

        Thanks.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/26#issuecomment-130176988 @youngwookim I add bigtop.mk file in this branch. Please check it! And Would I close PR which is #24? Thanks.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user youngwookim commented on the pull request:

        https://github.com/apache/bigtop/pull/26#issuecomment-130178916

        Thanks @eoriented

        #24 is obsolete, Should be closed i believe. Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user youngwookim commented on the pull request: https://github.com/apache/bigtop/pull/26#issuecomment-130178916 Thanks @eoriented #24 is obsolete, Should be closed i believe. Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented commented on the pull request:

        https://github.com/apache/bigtop/pull/26#issuecomment-130179240

        Ok.
        Thank you for the friendly words in your comments.

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented commented on the pull request: https://github.com/apache/bigtop/pull/26#issuecomment-130179240 Ok. Thank you for the friendly words in your comments.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user eoriented closed the pull request at:

        https://github.com/apache/bigtop/pull/24

        Show
        githubbot ASF GitHub Bot added a comment - Github user eoriented closed the pull request at: https://github.com/apache/bigtop/pull/24
        Hide
        warwithin YoungWoo Kim added a comment -

        It's ready to commit! Please assign to Minho Kim. Konstantin Boudnik? jay vyas?

        Show
        warwithin YoungWoo Kim added a comment - It's ready to commit! Please assign to Minho Kim . Konstantin Boudnik ? jay vyas ?
        Hide
        udanax Edward J. Yoon added a comment -

        I am +1 with this if no additional issue. and Thanks for kind review, YoungWoo

        Show
        udanax Edward J. Yoon added a comment - I am +1 with this if no additional issue. and Thanks for kind review, YoungWoo
        Hide
        warwithin YoungWoo Kim added a comment -

        Committed and pushed!

        Thanks Minho Kim and Edward J. Yoon. Welcome back, Apache Hama!

        Show
        warwithin YoungWoo Kim added a comment - Committed and pushed! Thanks Minho Kim and Edward J. Yoon . Welcome back, Apache Hama!

          People

          • Assignee:
            conquestor Minho Kim
            Reporter:
            udanax Edward J. Yoon
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development