Bigtop
  1. Bigtop
  2. BIGTOP-1070

Add BIGTOP_CLASSPATH functionality to tomcat deployment

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      BIGTOP-811 originally wanted to add the ability to detect SQL connectors and other plugins in standard locations and dynmically add them to the classpath. This effort stopped short when it became clear that a major architectural change was needed to make this work for Tomcat-based components. This was one of the main motivations for BIGTOP-939, which is now completed. We need to add a small snippet of code to integrate the two efforts, so the dynamic tomcat deployment can now use BIGTOP_CLASSPATH.

        Activity

        Sean Mackrory created issue -
        Hide
        Sean Mackrory added a comment -

        This patch modifies Oozie and Sqoop (the only Tomcat components that frequently require users to install SQL connectors, AFAIK) to build up BIGTOP_CLASSPATH, and if non-empty, to append it to Tomcat's classpath. This patch also adds a couple of suggestions from Mark Grover's review of BIGTOP-939 - mainly changing the use of "default" and "secure" in Oozie's configuration names to "http" and "https". I'm open to other suggestions if we don't like these names, I just personally didn't think it sounded comforting to the user the the default would be "non-secure".

        I also noticed while testing these changes, that BIGTOP-939 caused some problems when Oozie was installed and removed repeatedly (or upgraded). I was creating some symlinks post-install, but moved them to be part of the package contents directly. This appears to work well on openSUSE 12.3, RHEL 6, and Ubuntu Lucid - although I'm a tad hesitant because I know I've had problems with including absolute symlinks in packages before if the file they pointed to wasn't installed on the build system. I was a little surprised this worked. Anyone know more? Are we doing something to force package builds to allow this?

        Show
        Sean Mackrory added a comment - This patch modifies Oozie and Sqoop (the only Tomcat components that frequently require users to install SQL connectors, AFAIK) to build up BIGTOP_CLASSPATH, and if non-empty, to append it to Tomcat's classpath. This patch also adds a couple of suggestions from Mark Grover 's review of BIGTOP-939 - mainly changing the use of "default" and "secure" in Oozie's configuration names to "http" and "https". I'm open to other suggestions if we don't like these names, I just personally didn't think it sounded comforting to the user the the default would be "non-secure". I also noticed while testing these changes, that BIGTOP-939 caused some problems when Oozie was installed and removed repeatedly (or upgraded). I was creating some symlinks post-install, but moved them to be part of the package contents directly. This appears to work well on openSUSE 12.3, RHEL 6, and Ubuntu Lucid - although I'm a tad hesitant because I know I've had problems with including absolute symlinks in packages before if the file they pointed to wasn't installed on the build system. I was a little surprised this worked. Anyone know more? Are we doing something to force package builds to allow this?
        Sean Mackrory made changes -
        Field Original Value New Value
        Attachment 0001-BIGTOP-1070.-Add-BIGTOP_CLASSPATH-functionality-to-t.patch [ 12603846 ]
        Sean Mackrory made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Sean Mackrory added a comment -

        Just marking for inclusion in the 0.7 release

        Show
        Sean Mackrory added a comment - Just marking for inclusion in the 0.7 release
        Sean Mackrory made changes -
        Fix Version/s 0.7.0 [ 12324362 ]
        Priority Major [ 3 ] Blocker [ 1 ]
        Hide
        Roman Shaposhnik added a comment -

        +1. Sean Mackrory please commit

        Show
        Roman Shaposhnik added a comment - +1. Sean Mackrory please commit
        Hide
        Sean Mackrory added a comment -

        Roman Shaposhnik, would you mind giving this a quick re-review? I had to rebase it on top of some other recent fixes that have gone in and make minor changes. I also simplified the regular expression I was using in sed as that technique appears to not be supported on the older distros.

        Show
        Sean Mackrory added a comment - Roman Shaposhnik , would you mind giving this a quick re-review? I had to rebase it on top of some other recent fixes that have gone in and make minor changes. I also simplified the regular expression I was using in sed as that technique appears to not be supported on the older distros.
        Sean Mackrory made changes -
        Hide
        Roman Shaposhnik added a comment -

        +1

        Show
        Roman Shaposhnik added a comment - +1
        Sean Mackrory made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Roman Shaposhnik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Sean Mackrory
            Reporter:
            Sean Mackrory
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development