Bigtop
  1. Bigtop
  2. BIGTOP-1046

Pig's use of BIGTOP_DEFAULTS_DIR is evaluated at the wrong time

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      I'm having some troubles building pig for other reasons, so I've yet to actually verify the problem and solution, but I believe the way I inserted BIGTOP_DEFAULTS_DIR was incorrect for Pig. The here document will cause variables to be evaluated at build-time, but these variables should be evaluated at run-time. I should have escaped them. I've done another check of the original patch to see if I missed any other such occurrences, but it does appear I got them all.

        Activity

        Hide
        Sean Mackrory added a comment -

        Again - I've yet to actually verify the problem and solution on a physical system, and I will do so. I'm just posting this now in I'm hit by a bus before I do so.

        Show
        Sean Mackrory added a comment - Again - I've yet to actually verify the problem and solution on a physical system, and I will do so. I'm just posting this now in I'm hit by a bus before I do so.
        Hide
        Sean Mackrory added a comment -

        Submitting the patch for review - I've now confirmed that this is a problem and that my patch corrects the behavior.

        Show
        Sean Mackrory added a comment - Submitting the patch for review - I've now confirmed that this is a problem and that my patch corrects the behavior.
        Hide
        Sean Mackrory added a comment -

        Just marking for inclusion in the 0.7 release

        Show
        Sean Mackrory added a comment - Just marking for inclusion in the 0.7 release
        Hide
        Mark Grover added a comment -

        +1 Thanks Sean!

        Show
        Mark Grover added a comment - +1 Thanks Sean!

          People

          • Assignee:
            Sean Mackrory
            Reporter:
            Sean Mackrory
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development