Bigtop
  1. Bigtop
  2. BIGTOP-1045

Be consistent with shells, bigtop-detect-javahome, and bigtop-utils versions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None

      Description

      A while ago we decided to standardize on using /bin/bash (as opposed to /bin/sh), and to keep bigtop-detect-javahome in a centralized location. In addition to JAVA_HOME, there are now other scripts in bigtop-utils that are needed, so we should require the latest version.

      Until now, we've just been replacing /bin/sh when it's been a problem, but it's never obvious that it is the problem and is a low-risk change, so I'd like to just do a mass change now. With regards to bigtop-detect-javahome, we previously made this as a mass change, but several large patches were submitted soon thereafter and had been based off of older examples.

        Issue Links

          Activity

          Sean Mackrory created issue -
          Sean Mackrory made changes -
          Field Original Value New Value
          Attachment 0001-BIGTOP-1045.-Being-consistent-with-shells-defining-J.patch [ 12596976 ]
          Sean Mackrory made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Sean Mackrory made changes -
          Link This issue duplicates BIGTOP-716 [ BIGTOP-716 ]
          Sean Mackrory made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Roman Shaposhnik made changes -
          Fix Version/s 0.7.0 [ 12324362 ]
          Roman Shaposhnik made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Sean Mackrory
              Reporter:
              Sean Mackrory
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development