Uploaded image for project: 'Bigtop'
  1. Bigtop
  2. BIGTOP-1026

Big Top Mapred/Itest assertions should report specific commands which fail

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.8.0
    • Component/s: tests
    • Labels:
      None

      Description

      When running big top smokes, the iTest which invokes hadoop jobs could be much more informative if it printed the hadoop job command invoked.

      The org.apache.bigtop.itest and org.apache.bigtop.itest.hadoop.mapreduce both could be more revealing in failure conditions where:

      1) (itest package) the TestUtils.unpackTestResources(..) which can't be copied into the default HCFS file system — should be reported in the assertTrue calls.

      2) (mapreduce package) TestHadoopExamples.groovy - the MRExample should report the exact command that failed in the assertTrue call.

      1. BIGTOP-1026.patch
        0.9 kB
        Dasha Boudnik

        Activity

        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Looks like the second part of this ticket was actually resolved as part of BIGTOP-1057.

        Show
        dasha.boudnik Dasha Boudnik added a comment - Looks like the second part of this ticket was actually resolved as part of BIGTOP-1057 .
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        AssertTrue added for TestUtils.unpackTestResources.

        Show
        dasha.boudnik Dasha Boudnik added a comment - AssertTrue added for TestUtils.unpackTestResources.
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        jay vyas, any updates on this?

        Show
        dasha.boudnik Dasha Boudnik added a comment - jay vyas , any updates on this?
        Hide
        jayunit100 jay vyas added a comment -

        Hi dasha , i think this patch looks good to me . yes the 2nd has been resolved. +1 for this patch . thanks!

        Show
        jayunit100 jay vyas added a comment - Hi dasha , i think this patch looks good to me . yes the 2nd has been resolved. +1 for this patch . thanks!
        Hide
        dasha.boudnik Dasha Boudnik added a comment -

        Awesome; thank you, Jay!

        Show
        dasha.boudnik Dasha Boudnik added a comment - Awesome; thank you, Jay!
        Hide
        cos Konstantin Boudnik added a comment -

        Committed to master. Thanks Dasha!

        Show
        cos Konstantin Boudnik added a comment - Committed to master. Thanks Dasha!

          People

          • Assignee:
            dasha.boudnik Dasha Boudnik
            Reporter:
            jayunit100 jay vyas
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development