Bigtop
  1. Bigtop
  2. BIGTOP-102

daemons need to be taken care of when packages are installed/upgraded/uninstalled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.2.0
    • Component/s: General
    • Labels:
      None

      Description

      We need to make sure that all the packages that contain daemons/services exhibit the following behavior:

      • on installation they start (or don't start) the services depending on the defaults for the underlying OS
      • on upgrade services get restarted
      • on unistall services get shutdown
      1. BIGTOP-102.patch.txt
        30 kB
        Roman Shaposhnik

        Activity

        Hide
        Bruno Mahé added a comment -

        And even:

        • (Un)Register their services (which is different from starting or not starting them) on install/removal
        Show
        Bruno Mahé added a comment - And even: (Un)Register their services (which is different from starting or not starting them) on install/removal
        Hide
        Roman Shaposhnik added a comment -

        For the ease of review, here's a GitHub branch comparison link: https://github.com/rvs/bigtop/compare/origin...trunk

        Show
        Roman Shaposhnik added a comment - For the ease of review, here's a GitHub branch comparison link: https://github.com/rvs/bigtop/compare/origin...trunk
        Hide
        Andrew Bayer added a comment -

        All looks reasonable to me, but I really don't know what to look for, so probably should get looked over by someone who actually knows this stuff better. =)

        Show
        Andrew Bayer added a comment - All looks reasonable to me, but I really don't know what to look for, so probably should get looked over by someone who actually knows this stuff better. =)
        Hide
        Bruno Mahé added a comment -

        We should really start using revbiewboard for big patches at least.

        + force-reload|condrestart|try-restart)
        + is_oozie_alive
        + if [ $

        {STATUS}

        -eq 0 ] ; then
        + stop_oozie
        + start_oozie
        + fi
        + exit 0
        + ;;

        => Any reason to exit 0, but instead of reusing the status code of start_oozie (or the status of stop_oozie if it failed)

        + sed e 's#@FLUME_DAEMON@#$@#g' $< > debian/flume$@.init

        => Is creating/modifying files directly in debian/ ok in debian land? Or should we instread do that directly whet it is supposed to be installed?

        +# Short-Description: Cloudera Flume @FLUME_DAEMON@
        => It's Apache now

        Other than that, seems reasonable to me

        Show
        Bruno Mahé added a comment - We should really start using revbiewboard for big patches at least. + force-reload|condrestart|try-restart) + is_oozie_alive + if [ $ {STATUS} -eq 0 ] ; then + stop_oozie + start_oozie + fi + exit 0 + ;; => Any reason to exit 0, but instead of reusing the status code of start_oozie (or the status of stop_oozie if it failed) + sed e 's#@FLUME_DAEMON@#$@#g' $< > debian/flume $@.init => Is creating/modifying files directly in debian/ ok in debian land? Or should we instread do that directly whet it is supposed to be installed? +# Short-Description: Cloudera Flume @FLUME_DAEMON@ => It's Apache now Other than that, seems reasonable to me
        Hide
        Roman Shaposhnik added a comment -

        Apache revbiewboard doesn't work out-of-the-box with Git repos That's why I provided a GitHub diff url Did it not work for you?

        As for the comments:
        1. good point, although elsewhere Oozie does exit 0 so we probably have to fix that too
        2. I think modifying files in deb is OK – we need those files there for dh_installinit and that's the trick I've seen
        3. Cloudera Flume -> Apache Flume – totally! good catch!

        Show
        Roman Shaposhnik added a comment - Apache revbiewboard doesn't work out-of-the-box with Git repos That's why I provided a GitHub diff url Did it not work for you? As for the comments: 1. good point, although elsewhere Oozie does exit 0 so we probably have to fix that too 2. I think modifying files in deb is OK – we need those files there for dh_installinit and that's the trick I've seen 3. Cloudera Flume -> Apache Flume – totally! good catch!

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development