Bigtop
  1. Bigtop
  2. BIGTOP-100

Abstract component build logic from deb/rpm into common script

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2.0
    • Component/s: debian, rpm
    • Labels:
      None

      Description

      We currently duplicate the component build logic in both the Debian rules and RPM specs. We should abstract that away into common scripts, akin to the install_*.sh scripts.

      1. BIGTOP-100.diff.txt
        33 kB
        Andrew Bayer
      2. BIGTOP-100-mk2.diff.txt
        40 kB
        Andrew Bayer

        Activity

        Andrew Bayer created issue -
        Andrew Bayer made changes -
        Field Original Value New Value
        Assignee Andrew Bayer [ abayer ]
        Andrew Bayer made changes -
        Attachment BIGTOP-100.diff.txt [ 12495122 ]
        Andrew Bayer made changes -
        Attachment BIGTOP-100.diff.txt [ 12495122 ]
        Andrew Bayer made changes -
        Attachment BIGTOP-100.diff.txt [ 12495123 ]
        Andrew Bayer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Bruno Mahé added a comment -

        How has it been tested?

        • do-component-build must be referenced as SourceX in the spec files (and we should avoid calling directly scripts from RPM_SOURCE_FIR)
        Show
        Bruno Mahé added a comment - How has it been tested? do-component-build must be referenced as SourceX in the spec files (and we should avoid calling directly scripts from RPM_SOURCE_FIR)
        Hide
        Andrew Bayer added a comment -

        Fixing the source bit. As to RPM_SOURCE_DIR, I was just copying how install_*.sh were called - if you've got a better approach for that, I'm open to it.

        Show
        Andrew Bayer added a comment - Fixing the source bit. As to RPM_SOURCE_DIR, I was just copying how install_*.sh were called - if you've got a better approach for that, I'm open to it.
        Hide
        Roman Shaposhnik added a comment -

        +1, provided that it builds on RPM-based distros

        Show
        Roman Shaposhnik added a comment - +1, provided that it builds on RPM-based distros
        Hide
        Bruno Mahé added a comment -

        %

        {SOURCEX}

        where X is the index

        Show
        Bruno Mahé added a comment - % {SOURCEX} where X is the index
        Hide
        Andrew Bayer added a comment -

        Ok, then I'll redo all the spec files to have do-component-build as Source1 and install_.sh as Source2. fwiw, Oozie currently doesn't have either do-release-build (which it calls - replaced with do-component-build in this patch) or create-package-layout (its equivalent of install_.sh) as a SourceX.

        Show
        Andrew Bayer added a comment - Ok, then I'll redo all the spec files to have do-component-build as Source1 and install_ .sh as Source2. fwiw, Oozie currently doesn't have either do-release-build (which it calls - replaced with do-component-build in this patch) or create-package-layout (its equivalent of install_ .sh) as a SourceX.
        Hide
        Bruno Mahé added a comment -

        Well, it should
        You will also notice a similar hack in hadoop to copy multiple files. Hack which should be cleaned up as well.

        Show
        Bruno Mahé added a comment - Well, it should You will also notice a similar hack in hadoop to copy multiple files. Hack which should be cleaned up as well.
        Hide
        Andrew Bayer added a comment -

        New version of patch. Builds on CentOS.

        Show
        Andrew Bayer added a comment - New version of patch. Builds on CentOS.
        Andrew Bayer made changes -
        Attachment BIGTOP-100-mk2.diff.txt [ 12495156 ]
        Hide
        Bruno Mahé added a comment - - edited

        Did you check you didn't mess up any of the SOURCE reference you have been shuffling around?
        A cursory look seem fine though.

        Show
        Bruno Mahé added a comment - - edited Did you check you didn't mess up any of the SOURCE reference you have been shuffling around? A cursory look seem fine though.
        Hide
        Andrew Bayer added a comment -

        Yeah, I was careful there.

        Show
        Andrew Bayer added a comment - Yeah, I was careful there.
        Hide
        Bruno Mahé added a comment -

        +1

        Show
        Bruno Mahé added a comment - +1
        Andrew Bayer made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12633605 ] patch-available, re-open possible [ 12666169 ]
        Roman Shaposhnik made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 1 Andrew Bayer 19/Sep/11 19:48
        Patch Available Patch Available Resolved Resolved
        4h 28m 1 Andrew Bayer 20/Sep/11 00:16
        Resolved Resolved Closed Closed
        280d 16h 41m 1 Roman Shaposhnik 26/Jun/12 16:58

          People

          • Assignee:
            Andrew Bayer
            Reporter:
            Andrew Bayer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development