Beehive
  1. Beehive
  2. BEEHIVE-781

web service control leaks two input streams when creating a service control

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: V1Alpha, V1Beta, v1m1
    • Fix Version/s: None
    • Component/s: System Controls
    • Labels:
      None

      Description

      The web service control leaks two InputStreams in:

      ExtensionMaker
      genJCXForWSDLFile – the InputStream passed to the WSDLParser and passed to the XmlBeanWSDLParser are both leaked. They are also both the same, so we should use exactly one input stream instaed of two.

        Activity

        Hide
        Eddie O'Neil added a comment -

        Closing as per last comment.

        Show
        Eddie O'Neil added a comment - Closing as per last comment.
        Hide
        Eddie O'Neil added a comment -

        Fixed in SVN 190648. The InputStreams are no longer leaked as the DefinitionsDocument XMLBean is now created in one place and callers handle closing streams correctly.

        Show
        Eddie O'Neil added a comment - Fixed in SVN 190648. The InputStreams are no longer leaked as the DefinitionsDocument XMLBean is now created in one place and callers handle closing streams correctly.
        Hide
        daryoush mehrtash added a comment -

        The XMLBeanWSDLProcessor and WSDLParser should be modified to use DefinitionsDocument (XMLBean Object) instead of the Stream. It would avoid the duplication in this case, and also improves the code.

        Show
        daryoush mehrtash added a comment - The XMLBeanWSDLProcessor and WSDLParser should be modified to use DefinitionsDocument (XMLBean Object) instead of the Stream. It would avoid the duplication in this case, and also improves the code.

          People

          • Assignee:
            daryoush mehrtash
            Reporter:
            Eddie O'Neil
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development