Beehive
  1. Beehive
  2. BEEHIVE-401

dataGrid without configurePager 'hiding' overflow rows

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: V1Beta
    • Fix Version/s: V1Beta
    • Component/s: NetUI
    • Labels:
      None
    • Environment:
      Linux; Tomcat 2.0.28; Beehive SVN r156059

      Description

      If I define a Data Grid without specifying a pager, I expect to see all rows in my grid regardless of how many. The Data Grid actually cuts of the grid at 10 rows, but doesn't provide any way for me to see the other rows.

      <netui-data:dataGrid dataSource="pageFlow.users" name="users">
      <netui-data:header>
      <netui-data:headerCell headerText="Username"/>
      <netui-data:headerCell headerText="First"/>
      <netui-data:headerCell headerText="Last"/>
      <netui-data:headerCell headerText="Root"/>
      <netui-data:headerCell headerText="Locked"/>
      </netui-data:header>
      <netui-data:rows>
      <netui-data:anchorCell action="edit"
      value="$

      {container.item.username}

      ">
      <netui:parameter name="id" value="$

      {container.item.id}

      "/>
      </netui-data:anchorCell>
      <netui-data:spanCell value="$

      {container.item.firstName}

      "/>

      I cut off the source there, but I think that you get the idea. Here is the relevant HTML that is generated:

      Page 1 of 2   <a>Next</a>
      <table class="datagrid">
      <tr class="datagrid-header">
      <th class="datagrid">Username</th>
      <th class="datagrid">First</th>
      <th class="datagrid">Last</th>

      • jeremiah
      1. noPageAction.png
        10 kB
        Jeremiah Johnson
      2. BEEHIVE-401.tar
        20 kB
        Jeremiah Johnson

        Activity

        Hide
        Eddie O'Neil added a comment -

        Hm. I'm not sure that the default behavior should be "show all". This is almost never what one wants to have happen, and it will almost always require a configurePager tag just to get paging running.

        The alternative is to have the default behavior be to show 10 rows per page with a pager and be able to show all rows by using the configurePager tag.

        Is your goal to be able to just display all? If so, would the latter solution be sufficient?

        Show
        Eddie O'Neil added a comment - Hm. I'm not sure that the default behavior should be "show all". This is almost never what one wants to have happen, and it will almost always require a configurePager tag just to get paging running. The alternative is to have the default behavior be to show 10 rows per page with a pager and be able to show all rows by using the configurePager tag. Is your goal to be able to just display all? If so, would the latter solution be sufficient?
        Hide
        Eddie O'Neil added a comment -

        This sounds l ike a bug in the pager; can you attach a full repro?

        Show
        Eddie O'Neil added a comment - This sounds l ike a bug in the pager; can you attach a full repro?
        Hide
        Jeremiah Johnson added a comment -

        Here is a screen shot to be specific about the issue. Notice that Next is not a link, so I can't get to page 2.

        • jeremiah
        Show
        Jeremiah Johnson added a comment - Here is a screen shot to be specific about the issue. Notice that Next is not a link, so I can't get to page 2. jeremiah
        Hide
        Eddie O'Neil added a comment -

        Jeremiah--hey; any progress on getting a repro together for this?

        Thanks!

        Show
        Eddie O'Neil added a comment - Jeremiah--hey; any progress on getting a repro together for this? Thanks!
        Hide
        Jeremiah Johnson added a comment -

        Here are the steps that I recommend for using the attached BEEHIVE-401.tar file:
        $ tar xf BEEHIVE-401.tar
        $ cd BEEHIVE-401
        $ ant -f $BEEHIVE_HOME/ant/webappRuntimeCore.xml -Dwebapp.dir=/home/jjohnson/projects/BEEHIVE-401 deploy.beehive.webapp.runtime
        $ ant -f $BEEHIVE_HOME/ant/buildWebapp.xml -Dwebapp.dir=/home/jjohnson/projects/BEEHIVE-401 build
        $ jar cf BEEHIVE-401.war *
        $ mv BEEHIVE-401.war $CATALINA_HOME/webapps

        Then point your browser at http://localhost:8080/BEEHIVE-401/

        You should see a page with a basic grid. There is the word 'Next' above the grid, but it is not an anchor. From past discussions, I believe that Next should be a link to current page but show item 11.

        • jeremiah
        Show
        Jeremiah Johnson added a comment - Here are the steps that I recommend for using the attached BEEHIVE-401 .tar file: $ tar xf BEEHIVE-401 .tar $ cd BEEHIVE-401 $ ant -f $BEEHIVE_HOME/ant/webappRuntimeCore.xml -Dwebapp.dir=/home/jjohnson/projects/ BEEHIVE-401 deploy.beehive.webapp.runtime $ ant -f $BEEHIVE_HOME/ant/buildWebapp.xml -Dwebapp.dir=/home/jjohnson/projects/ BEEHIVE-401 build $ jar cf BEEHIVE-401 .war * $ mv BEEHIVE-401 .war $CATALINA_HOME/webapps Then point your browser at http://localhost:8080/BEEHIVE-401/ You should see a page with a basic grid. There is the word 'Next' above the grid, but it is not an anchor. From past discussions, I believe that Next should be a link to current page but show item 11. jeremiah
        Hide
        Eddie O'Neil added a comment -

        Fixed with SVN 156543. The behavior in absence of a <netui-data:configurePager> tag is that the current request URI is used for paging next time.

        Show
        Eddie O'Neil added a comment - Fixed with SVN 156543. The behavior in absence of a <netui-data:configurePager> tag is that the current request URI is used for paging next time.
        Hide
        Eddie O'Neil added a comment -

        Oh, and thanks for the great / concise repro. It now makes up the j401 verification test.

        Show
        Eddie O'Neil added a comment - Oh, and thanks for the great / concise repro. It now makes up the j401 verification test.
        Hide
        Jeremiah Johnson added a comment -

        Looks good; thanks.

        • jeremiah
        Show
        Jeremiah Johnson added a comment - Looks good; thanks. jeremiah

          People

          • Assignee:
            Jeremiah Johnson
            Reporter:
            Jeremiah Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development