Uploaded image for project: 'Beehive'
  1. Beehive
  2. BEEHIVE-361

Redundant form-bean type information in generated Struts XML when form class extends ActionForm

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • V1Beta
    • V1Beta
    • NetUI
    • None

    Description

      Consider the following two form beans:

      package test;
      public class Form1 extends ActionForm
      {
      }

      package test;
      public class Form2
      {
      }

      In a page flow that uses these two form beans, you get the following two form-bean elements in the generated Struts XML:

      <form-bean name="form1" type="org.apache.beehive.netui.pageflow.internal.AnyBeanActionForm" className="org.apache.beehive.netui.pageflow.config.PageFlowActionFormBean">
      <set-property property="actualType" value="test.Form1"/>
      </form-bean>

      <form-bean name="form2" type="test.Form2" className="org.apache.beehive.netui.pageflow.config.PageFlowActionFormBean">
      <set-property property="actualType" value="test.Form2"/>
      </form-bean>

      In the second form-bean, the "actualType" custom property is unnecessary; the runtime should be able to use the type attribute in a normal form-bean:
      <form-bean name="form2" type="test.Form2"/>

      This isn't a vital issue, but it is causing clutter in the generated Struts XML, and the fix is easy...

      Attachments

        Activity

          People

            kbaker Krista Baker
            rich Richard Feit
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: