Uploaded image for project: 'Beehive'
  1. Beehive
  2. BEEHIVE-1176

Improve NetUI AP perf by reducing the number of calls to PackageDeclaration.getPackage()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.0.1, 1.0.2
    • V.Next
    • NetUI
    • None

    Description

      The NetUI annotation processors make calls to TypeDeclaration.getPackage() in various places. This is not always a simple and fast call, In some APT cases, to create a PackageDeclaration involves bringing the entire
      package into memory, which involves reading jar files. With some first passes of profiling I noticed we were spending lots of time in calls to org.apache.beehive.netui.compiler.typesystem.impl.declaration.TypeDeclarationImpl.getPackage(). In most cases we just use the PackageDeclaration to get the package name. This could be avoided by just getting the fully qualified name of the TypeDeclaration and stripping off the class name portion to get the package name.

      Attachments

        Activity

          People

            crogers Howard Carlin Rogers
            crogers Howard Carlin Rogers
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: