[BEANUTILS-44] FloatLocaleConverter cannot parse negative values

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0
• Component/s: Locale BeanUtils / Converters

Environment

Operating System: All
Platform: All

• Bugzilla Id: 33841
• Assignee: Niall Pemberton
• Reporter: Paul Jenkins
• Created: 04/Mar/05 19:06
• Updated: 25/Mar/08 08:07
• Resolved: 12/Jul/07 04:57

Description

Problem found in Build 1.7

LocaleBeanUtils.setProperty(bean, name, value);

Does not handle negative values. When processing negative values the
FloatLocaleConverter.parse(value, pattern) throws a ConversionException because
of the following if test: -

if(Math.abs(parsed.doubleValue() - parsed.floatValue()) >
parsed.floatValue() * 0.00001) {
throw new ConversionException(...);
}

This test will always fail for a valid negative value because the
multiplication by 0.00001 will result in a negative value which will be less
then the abs subtraction.

A solution to this problem would be to check Math.abs(parsed.floatValue() *
0.00001)

We also suffer from the previously reported problem of the locale converters
not supporting boolean to get round this problem we have to determine the
property type and call either LocaleBeanUtils.setProperty() or
BeanUtils.setProperty() this would be made easier if the: -

protected Descriptor calculate(Object bean, String name)

method was made public.