[BEANUTILS-351] FloatLocaleConverter cannot parse 0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.1
• Component/s: Locale BeanUtils / Converters
• Assignee: Niall Pemberton
• Reporter: Lucian Chirita
• Created: 01/Jul/09 12:07
• Updated: 25/Sep/16 22:16
• Resolved: 04/Aug/09 21:33

Description

FloatLocaleConverter fails to parse the "0" string, complaining that the value is not of type Float.

Doing new LocaleConvertUtilsBean().convert("0", Float.class, Locale.US, null) results in the following exception:

Exception in thread "main" org.apache.commons.beanutils.ConversionException: Supplied number is not of type Float: 0
at org.apache.commons.beanutils.locale.converters.FloatLocaleConverter.parse(FloatLocaleConverter.java:222)
at org.apache.commons.beanutils.locale.BaseLocaleConverter.convert(BaseLocaleConverter.java:232)
at org.apache.commons.beanutils.locale.LocaleConvertUtilsBean.convert(LocaleConvertUtilsBean.java:285)
at Code.main(Code.java:65)

Looking at the source of FloatLocaleConverter, line 221 which originally reads

if (posDouble < Float.MIN_VALUE || posDouble > Float.MAX_VALUE) {

should be changed to

if ((posDouble > 0 && posDouble < Float.MIN_VALUE) || posDouble > Float.MAX_VALUE) {

in order to fix the bug.