[BEANUTILS-336] MappedPropertyDescriptor#reLoadClass() possible NPE / odd code; also swallows Throwable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.1
• Component/s: Bean / Property Utils
• Assignee: Niall Pemberton
• Reporter: Sebb
• Created: 17/Feb/09 00:08
• Updated: 25/Sep/16 22:16
• Resolved: 04/Aug/09 00:39

Description

MappedPropertyDescriptor#reLoadClass() possible NPE / odd code

private Class reLoadClass() {
    ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
    // Try the context class loader
    if (classLoader != null) {
        try {
             return classLoader.loadClass(className);
        } catch (Throwable t) {
             // ignore
        }
    }
    // Try this class's class loader
    try {
        return classLoader.loadClass(className);
    } catch (Throwable t) {
        return null;
    }
}

The second call to classLoader.loadClass(className) is likely to fail with NPE - if it is ever called.

The comments suggest that the second loadClass() invocation should be done using a different class loader, however this is not done.

Does the code really want to try loading the class twice using the same classloader?
This is what will happen if the initial loadClass() fails.

Another problem with the code is that it swallows Throwable.
It would be better to catch just the expected Exceptions - or even Exception, but not Throwable.