[BEANUTILS-241] BeanComparator throws wrong exception and hides cause

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6
• Fix Version/s: 1.8.0
• Assignee: Unassigned
• Reporter: Chris Hyzer
• Created: 11/Jun/06 10:09
• Updated: 12/Sep/06 23:13
• Resolved: 12/Sep/06 23:13

Description

BeanComparator does this:

catch ( Exception e )

{ throw new ClassCastException( e.toString() ); }

In my case, it was a getter throwing an exception, so it wasnt a ClassCastException, but BeanComparator threw as such. I couldnt see what the real exception was since the exception was not propagated as cause. I recommend:

catch(Exception e) {
if (e instanceof RuntimeException)

{ throw (RuntimeException)e; }

//if this isnt available in the java version you are targetting, the above line will improve things...
throw new RuntimeException(e);
}