Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.8.0
    • None
    • None
    • Operating System: Linux
      Platform: Other

    • 32230

    Description

      Hi,

      I was examining the source for beanutils using Eclipse. There were several
      warnings given, which I have fixed with the attached patches.

      These patches are pretty straightforeward, I think.

      Attachments

        Activity

          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13436)
          fixes local variable not read warning

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13436) fixes local variable not read warning
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13437)
          fix warnings

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13437) fix warnings
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13438)
          fixes private never used warnings

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13438) fixes private never used warnings
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13439)
          removes some commented code

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13439) removes some commented code
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13440)
          fixes empty block should be commented warnings, NOTE: needs better comments

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13440) fixes empty block should be commented warnings, NOTE: needs better comments
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13441)
          fixes static used improperly warnings

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13441) fixes static used improperly warnings
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13442)
          removes unused imports from beanutils/src/java

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13442) removes unused imports from beanutils/src/java
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13443)
          fixes unnecessary semicolon warnings

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13443) fixes unnecessary semicolon warnings
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13444)
          fixes unnecessary else statement warnings for beanutils/src/test

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13444) fixes unnecessary else statement warnings for beanutils/src/test
          chris.tilden@gmail.com Chris Tilden added a comment -

          Created an attachment (id=13445)
          removes unused imports from beanutils/src/test

          chris.tilden@gmail.com Chris Tilden added a comment - Created an attachment (id=13445) removes unused imports from beanutils/src/test
          bayard Henri Yandell added a comment -

          Apply to 1.8.0 - or repeat using Eclipse if the source is too changed.

          bayard Henri Yandell added a comment - Apply to 1.8.0 - or repeat using Eclipse if the source is too changed.
          bayard Henri Yandell added a comment -

          Applied:

          r469737 - remove-unused-code.patch
          r469728 - remove-unused-imports-test.patch
          r469729 - local-variable-not-read-warning-fix.patch
          r469730 - field-hiding-another-field-warning-fix.patch
          r469731 - empty-block-should-be-documented-warning-fix-java.patch
          r469732 - static-used-improperly-warning-fix.patch
          r469736 - unnecessary-semicolon-fix-java.patch
          r469740 - remove-unused-imports-java.patch

          private-never-read-warning-fix.patch was already fixed.

          I'm punting the unnecessary-else fix. I'm not a huge fan of the style of ending with an if/else, but I do think it's a style thing rather than something that can be considered wrong.

          bayard Henri Yandell added a comment - Applied: r469737 - remove-unused-code.patch r469728 - remove-unused-imports-test.patch r469729 - local-variable-not-read-warning-fix.patch r469730 - field-hiding-another-field-warning-fix.patch r469731 - empty-block-should-be-documented-warning-fix-java.patch r469732 - static-used-improperly-warning-fix.patch r469736 - unnecessary-semicolon-fix-java.patch r469740 - remove-unused-imports-java.patch private-never-read-warning-fix.patch was already fixed. I'm punting the unnecessary-else fix. I'm not a huge fan of the style of ending with an if/else, but I do think it's a style thing rather than something that can be considered wrong.

          People

            Unassigned Unassigned
            chris.tilden@gmail.com Chris Tilden
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: