[BEAM-85] PAssert needs sanity check that it's used correctly

• Type: New Feature
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: sdk-java-core
• Labels: Done
• Assignee: Stas Levin
• Reporter: Dan Halperin
• Created: 02/Mar/16 01:00
• Updated: 06/Oct/20 21:52
• Resolved: 17/Dec/16 22:26

Description

We should validate two things:

1. DataflowAssert is not added to a pipeline that has already been run.
2. The pipeline is run after the DataflowAssert is added.

If either of these are not validated, then it is possible that the test doesn't actually verify anything.

This code should throw an assertion error or fail in some other way.

Pipeline p = TestPipeline.create();
PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
p.run();

DataflowAssert.thatSingleton(value).isEqualTo(true);

but it would pass silently.

similarly, this code wills pass silently:

Pipeline p = TestPipeline.create();
PCollection<Boolean> value = p.apply(Create.of(Boolean.FALSE));
DataflowAssert.thatSingleton(value).isEqualTo(true);

Issue Links

• links to: GitHub Pull Request #1595