[BEAM-8350] Upgrade to pylint 2.4

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: sdk-py-core
• Assignee: Chad Dombrova
• Reporter: Chad Dombrova
• Created: 03/Oct/19 23:26
• Updated: 24/Jul/20 20:02
• Resolved: 12/Feb/20 22:07

Description

pylint 2.4 provides a number of new features and fixes, but the most important/pressing one for me is that 2.4 adds support for understanding python type annotations, which fixes a bunch of spurious unused import errors in the PR I'm working on for BEAM-7746.

As of 2.0, pylint dropped support for running tests in python2, so to make the upgrade we have to move our lint jobs to python3. Doing so will put pylint into "python3-mode" and there is not an option to run in python2-compatible mode. That said, the beam code is intended to be python3 compatible, so in practice, performing a python3 lint on the Beam code-base is perfectly safe. The primary risk of doing this is that someone introduces a python-3 only change that breaks python2, but these would largely be syntax errors that would be immediately caught by the unit and integration tests.

Issue Links

• links to: GitHub Pull Request #9725