Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-8030

Make VarIntCoder overflow behavior consistent

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • sdk-py-core
    • None

    Description

      The fast version of OutputStream.write_var_int_64 (and thus VarIntCoder.encode) throws OverflowError for ints larger than 64 bits, but the slow version does not. We should make them both throw an error.

      We may also want to add a write_var_int_32 that uses the same format, but will throw an error for ints larger than 32 bits, for use in RowCoder.

      Attachments

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. BEAM-7996 Add support for remaining data types in python RowCoder

          • P1 - Critical bug: data loss, total loss of function, or loss of testing signal due to test failures or flakiness
          • Open

          Activity

            People

              Unassigned Unassigned
              bhulette Brian Hulette
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: