Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-8017

Plumb errors and remove panics from package graphx

Details

    Description

      The graphx package, and in particular serialize.go and coder.go should be returning errors back up, rather than panicing when issues occur deeper when marshalling types. It makes errors harder to follow since there's now a less necessary panic trace to skip, rather than a clearly constructed error message.

      Not difficult, but may be tedious. Requires plumbing the errors and handling/wrapping them appropriately instead of using panic. Most error handling is presently correctly wrapped anyway.

      The graphx package as a rule is intended for beam internal use, and not part of the user surface, so making the API changes (which aren't backwards compatible) isn't the worst. Most of the affected methods are unexported.

      Attachments

        Issue Links

          Activity

            People

              jingc Jing Chen
              lostluck Robert Burke
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 20m
                  1h 20m