[BEAM-7891] gRPC vendoring contains overlapping classes

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.15.0
• Component/s: build-system
• Assignee: Luke Cwik
• Reporter: Romain Manni-Bucau
• Created: 05/Aug/19 08:44
• Updated: 16/May/20 14:18
• Resolved: 05/Mar/20 20:30

Description

In 2.14 the overlapping bug between modules is still not fixed, it still prevents to use beam with some JVM, pollutes a lot shadowing/uber jar creation and can prevent beam to run under some classloading setup (potentielly in an engine/runner). Here is one example:

 

[INFO] [WARNING] beam-vendor-grpc-1_13_1-0.2.jar, beam-vendor-sdks-java-extensions-protobuf-2.14.0.jar define 1814 overlapping classes:
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.collect.ImmutableMapValues$1
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.util.concurrent.ImmediateFuture$ImmediateCancelledFuture
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.base.Converter$ReverseConverter
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.hash.HashCode$IntHashCode
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.collect.Iterables$8$1
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.collect.HashBiMap
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.cache.CacheBuilderSpec$WriteDurationParser
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.collect.Multiset$Entry
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.graph.AbstractValueGraph
[INFO] [WARNING] - org.apache.beam.vendor.grpc.v1p13p1.com.google.common.util.concurrent.InterruptibleTask

This task is indeed about fixing the overlappings but also ensuring it can't come in 2.15 since all versions are affected since vendoring had been set up and it never had been cleanly fixed on all the build.

 

Thanks