Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-7520

DirectRunner timers are not strictly time ordered

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • 2.13.0
    • 2.17.0
    • runner-direct
    • None

    Description

      Let's suppose we have the following situation:

      • statful ParDo with two timers - timerA and timerB
      • timerA is set for window.maxTimestamp() + 1
      • timerB is set anywhere between <windowStart, windowEnd), let's denote that timerB.timestamp
      • input watermark moves to BoundedWindow.TIMESTAMP_MAX_VALUE

      Then the order of timers is as follows (correct):

      • timerB
      • timerA

      But, if timerB sets another timer (say for timerB.timestamp + 1), then the order of timers will be:

      • timerB (timerB.timestamp)
      • timerA (BoundedWindow.TIMESTAMP_MAX_VALUE)
      • timerB (timerB.timestamp + 1)

      Which is not ordered by timestamp. The reason for this is that when the input watermark update is evaluated, the WatermarkManager,extractFiredTimers() will produce both timerA and timerB. That would be correct, but when timerB sets another timer, that breaks this.

      Attachments

        Issue Links

          Activity

            People

              janl Jan Lukavský
              janl Jan Lukavský
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 21h 10m
                  21h 10m