[BEAM-682] Invoker Class should be created in Thread Context Classloader

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 0.3.0-incubating
• Fix Version/s: 2.3.0
• Component/s: sdk-java-core
• Labels: Done
• Flags: Important
• Assignee: Romain Manni-Bucau
• Reporter: Sumit Chawla
• Created: 26/Sep/16 23:43
• Updated: 06/Oct/20 21:58
• Resolved: 13/Jan/18 07:03

Description

As of now the InvokerClass is being loaded in wrong classloader. It should be loaded into Thread.currentThread.getContextClassLoader()

https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokers.java#L167

 Class<? extends DoFnInvoker<?, ?>> res =
        (Class<? extends DoFnInvoker<?, ?>>)
            unloaded
                .load(DoFnInvokers.class.getClassLoader(), ClassLoadingStrategy.Default.INJECTION)
                .getLoaded();

Fix

 Class<? extends DoFnInvoker<?, ?>> res =
        (Class<? extends DoFnInvoker<?, ?>>)
            unloaded
                .load(Thread.currentThread().getContextClassLoader(),
                        ClassLoadingStrategy.Default.INJECTION)
                .getLoaded();

Issue Links

• links to: GitHub Pull Request #1013
• links to: GitHub Pull Request #4235