[BEAM-6339] In certain cases, spotlessJava fails to work

• Type: Improvement
• Status: Resolved
• Priority: P4
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: build-system
• Assignee: Ruoyun Huang
• Reporter: Ruoyun Huang
• Created: 02/Jan/19 19:53
• Updated: 24/Jul/20 19:57
• Resolved: 10/Jan/19 00:02

Description

Encounter following error when certain criteria exists in new code: 

 

> Task :beam-runners-google-cloud-dataflow-java:spotlessJava FAILED

 

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':beam-runners-google-cloud-dataflow-java:spotlessJava'.
  > You have a misbehaving rule which can't make up its mind.
  This means that spotlessCheck will fail even after spotlessApply has run.

This is a bug in a formatting rule, not Spotless itself, but Spotless can
work around this bug and generate helpful bug reports for the broken rule
if you add 'paddedCell()' to your build.gradle as such:

spotless {
format 'someFormat',

{ ... paddedCell() }

}

The next time you run spotlessCheck, it will put helpful bug reports into
'runners/google-cloud-dataflow-java/build/spotless-diagnose-java', and spotlessApply
and spotlessCheck will be self-consistent from here on out.

For details see https://github.com/diffplug/spotless/blob/master/PADDEDCELL.md

Issue Links

• links to: GitHub Pull Request #7390