[BEAM-5967] ProtoCoder doesn't support DynamicMessage

• Type: Improvement
• Status: Triage Needed
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.17.0
• Component/s: sdk-java-core
• Labels: Done
• Assignee: Alex Van Boxel
• Reporter: Alex Van Boxel
• Created: 05/Nov/18 09:22
• Updated: 13/Apr/23 10:57
• Resolved: 31/Aug/19 05:40

Description

The ProtoCoder does make some assumptions about static messages being available. The DynamicMessage doesn't have some of them, mainly because the proto schema is defined at runtime and not at compile time.

Does it make sense to make a special coder for DynamicMessage or build it into the normal ProtoCoder.

Here is an example of the assumtion being made in the current Codec:

try {
  @SuppressWarnings("unchecked")
  T protoMessageInstance = (T) protoMessageClass.getMethod("getDefaultInstance").invoke(null);
  @SuppressWarnings("unchecked")
  Parser<T> tParser = (Parser<T>) protoMessageInstance.getParserForType();
  memoizedParser = tParser;
} catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
  throw new IllegalArgumentException(e);
}

Issue Links

• links to: GitHub Pull Request #8496