[BEAM-569] JMS IO should set maxNumRecords to Long.MAX_VALUE by default

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 0.3.0-incubating
• Component/s: io-java-jms
• Assignee: Jean-Baptiste Onofré
• Reporter: Jean-Baptiste Onofré
• Created: 19/Aug/16 11:34
• Updated: 16/May/20 13:46
• Resolved: 30/Aug/16 19:48

Description

When using JmsIO this way:

JmsIO.read().withConnectionFactory(connectionFactory).withQueue("queue")

the user expects to work in unbounded mode. However, as the maxNumRecords value is not set by default in JmsIO, the default value set is 0 (as it's a long). It means that the JmsIO.read() just doesn't consume any message and exit directly.

IMHO, it makes sense to define the maxNumRecords value to Long.MAX_VALUE by default. Thanks to that, JmsIO.read() will really work in unbounded form.

Issue Links

• links to: GitHub Pull Request #898