[BEAM-5115] Inconsistent use of ValueProvider between XmlSource and XmlIO

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.12.0
• Component/s: io-java-xml
• Assignee: Ismaël Mejía
• Reporter: Sigmund Hansen
• Created: 09/Aug/18 13:06
• Updated: 16/May/20 14:06
• Resolved: 18/Mar/19 13:32

Description

XmlIO.Read.from takes a String as an argument, which is then used to create a StaticValueProvider for the XmlSource that is built later on. As XmlSource takes a ValueProvider<String> to specify the file source(s) to read from.

I would suggest to store a ValueProvider<String> in XmlIO.Read.Builder instead of a String, and overload from with two implementations. One being a wrapper creating a StaticValueProvider, i.e.

public Read<T> from(String fileOrPatternSpec) {
    return from(StaticValueProvider.of(fileOrPatternSpec));
}

public Read<T> from(ValueProvider<String> fileOrPatternSpec) {
    return toBuilder().setFileOrPatternSpec(fileOrPatternSpec).build();
}

Issue Links

• is duplicated by: BEAM-8948 ValueProvider support for read method of XML IO connector
• links to: GitHub Pull Request #8068