Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-4375

Gradle doesn't run tests under RunWith(Enclosed.class)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P0
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0
    • Component/s: build-system
    • Labels:
      None

      Description

      If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at the produced test report, one can see that it is missing tests that have RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc.

       

      This is very very bad - some of these tests are already known to be (silently) broken.

       

      Likely https://github.com/gradle/gradle/issues/2985 . As an emergency measure, let's convert to top-level classes.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                swegner Scott Wegner
                Reporter:
                jkff Eugene Kirpichov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h