[BEAM-4375] Gradle doesn't run tests under RunWith(Enclosed.class)

• Type: Bug
• Status: Resolved
• Priority: P0
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Component/s: build-system
• Assignee: Scott Wegner
• Reporter: Eugene Kirpichov
• Created: 21/May/18 18:53
• Updated: 24/Jul/20 20:20
• Resolved: 24/May/18 15:34

Description

If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at the produced test report, one can see that it is missing tests that have RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc.

 

This is very very bad - some of these tests are already known to be (silently) broken.

 

Likely https://github.com/gradle/gradle/issues/2985 . As an emergency measure, let's convert to top-level classes.

Issue Links

• links to: GitHub Pull Request #5440