[BEAM-4353] Enforce ErrorProne analysis in the solr IO project

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Component/s: io-java-solr
• Labels: errorprone starter
• Assignee: Tim Robertson
• Reporter: Scott Wegner
• Created: 17/May/18 22:39
• Updated: 16/May/20 13:21
• Resolved: 18/May/18 13:40

Description

Java ErrorProne static analysis was recently enabled in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to make sdks-java-core ErrorProne-clean and add enforcement. This task is clean ErrorProne warnings and add enforcement in beam-sdks-java-io-solr. Additional context discussed on the dev list.

Fixing this issue will involve:

1. Follow instructions in the Contribution Guide to set up a beam development environment.
2. Run the following command to compile and run ErrorProne analysis on the project: ./gradlew :beam-sdks-java-io-solr:assemble
3. Fix each ErrorProne warning from the sdks/java/io/solr project.
4. In sdks/java/io/solr/build.gradle, add failOnWarning: true to the call the applyJavaNature() (example).

This starter issue is sponsored by swegner. Feel free to reach out with questions or code review:

• JIRA: swegner
• GitHub: @swegner
• Slack: @Scott Wegner
• Email: swegner at google dot com

Issue Links

• links to: GitHub Pull Request #5419