Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-4342

Enforce ErrorProne analysis in the hadoop IO projects

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      Java ErrorProne static analysis was recently enabled in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to make sdks-java-core ErrorProne-clean and add enforcement. This task is clean ErrorProne warnings and add enforcement in beam-sdks-java-io-hadoop-*. Additional context discussed on the dev list.

      Fixing this issue will involve:

      1. Follow instructions in the Contribution Guide to set up a beam development environment.
      2. Run the following command to compile and run ErrorProne analysis on the project: ./gradlew :beam-sdks-java-io-hadoop-common:assemble :beam-sdks-java-io-hadoop-file-system:assemble :beam-sdks-java-io-hadoop-input-format:assemble
      3. Fix each ErrorProne warning from the sdks/java/io/hadoop* projects.
      4. In sdks/java/io/hadoop-common/build.gradle, sdks/java/io/hadoop-file-system/build.gradle, and sdks/java/io/hadoop-input-format/build.gradle, add failOnWarning: true to the call the applyJavaNature() (example).

      This starter issue is sponsored by Scott Wegner. Feel free to reach out with questions or code review:

        Attachments

          Activity

            People

            • Assignee:
              timrobertson100 Tim Robertson
              Reporter:
              swegner Scott Wegner

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                  Issue deployment