[BEAM-4261] BigtableIO should not try to validate runtime parameters at construction time.

• Type: Bug
• Status: Resolved
• Priority: P3
• Resolution: Won't Fix
• Fix Version/s: Missing
• Component/s: io-java-gcp
• Assignee: Unassigned
• Reporter: Kevin Si
• Created: 09/May/18 13:55
• Updated: 13/Jan/22 21:52
• Resolved: 23/Jan/21 02:38

Description

The workaround for user is to have some default values set and override them at runtime.

One example of validating runtime parameter at construction time is following, and there are could be more.

 
    @Override
    public void validate()

{       ValueProvider<String> tableId = config.getTableId();       checkArgument(tableId != null && tableId.isAccessible() && !tableId.get().isEmpty(),         "tableId was not supplied");     }

 
A reported issue on stackoverflow: https://stackoverflow.com/questions/49595921/valueprovider-type-parameters-not-getting-honored-at-the-template-execution-time
 
One concern I have is that if we disable the validation at construction time, how do we validate it at runtime? Ideally, users should use template parameter metadata for validation, but that is optional.