Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-3279

Deprecate and remove Coder consistentWithEquals in favor of overriding structuredValue

Details

    • Improvement
    • Status: Resolved
    • P3
    • Resolution: Done
    • None
    • Missing
    • sdk-java-core

    Description

      Summary of discussion linked below:
      consistentWithEquals() is redundant w.r.t. structuralValue(), and should be deprecated. I think our mutation detectors are already using structuralValue(), so the work here would be to simply mark the method deprecated, remove all remaining overrides in the SDK, and document that overriding the method is a no-op.

      https://lists.apache.org/thread.html/8b2dcf09ba8e46b3c008293d99e4028d10463148b68326687dc29a4d@%3Cdev.beam.apache.org%3E

      Attachments

        Issue Links

          Activity

            People

              AlexKbit Alexander Savchenko
              kenn Kenneth Knowles
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 5h 10m
                  5h 10m