Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-3046

De-javafy the Python Metrics API

Agile BoardAttach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      For example, though Java forces one to put all stand-alone functions as static methods on a class (like Metrics) in Python one would just have standard module-level functions.

      Also, the MetricsFilter builder pattern is very Java-esque (and verbose). In Python, one would simply let result.metrics() take keyword arguments.

      We should seriously consider aggregating rather than returning lists of results, at least by default. E.g. in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/wordcount.py it assumes that there's no other metric with the given name in any subtransform (otherwise it may deterministically grab the "wrong" one.)

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Anand Inguva Ananda Prasad Inguva
            robertwb Robert Bradshaw

            Dates

              Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 1h 50m
              1h 50m

              Issue deployment