[BEAM-2282] logic in function accept in BeamSqlExpression

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: dsl-sql
• Labels: Done dsl_sql_merge
• Assignee: James Xu
• Reporter: Mingmin Xu
• Created: 12/May/17 16:26
• Updated: 24/Jul/20 20:11
• Resolved: 20/Jun/17 17:41

Description

Method accept is used to make sure the SQL operator is supported in Beam SQL. IMO it should only check the case that some scenarios are not supported in BeamSQL even it's valid in Calcite SQL grammar.

It's not necessary to my understand to validate SQL grammar as that's done already in the parsing phase.