[BEAM-2069] Remove ResourceId.getCurrentDirectory()?

• Type: Bug
• Status: Open
• Priority: P3
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: sdk-java-core
• Labels: Clarified backward-incompatible
• Assignee: Unassigned
• Reporter: Stephen Sisk
• Created: 24/Apr/17 23:18
• Updated: 03/Jun/22 17:25

Description

Beam ResourceId currently has a getCurrentDirectory method that returns the current resource id if it's a directory, or the parent directory if it's a directory.

To implement this you need to know whether or not a particular path is a directory or not.

I'm trying to implement the Hadoop ResourceId implementation, and it's not clear if it's possible. Hadoop's Paths do not end a / if they are a directory (they are stripped), nor do hadoop paths tell you if something is a directory, so it's not possible to determine if a given path is a file that does not have a suffix, or a directory.

It's not clear to me that all file systems can determine whether a path is a directory and thus I don't believe it can be implemented reliably.

The only usages of getCurrentDirectory that I could find are in tests so it's not clear we actually need this.

I propose that we remove this method.

cc davor

Issue Links

• is superceded by: BEAM-2283 Consider using actual URIs instead of Strings/ResourceIds in relation to FileSystems