[BEAM-1962] Connection should be closed in case start() throws exception

• Type: Bug
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: io-java-jms
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 13/Apr/17 16:17
• Updated: 16/May/20 13:15
• Resolved: 22/May/19 09:49

Description

In JmsIO#start() :

      try {
        Connection connection;
        if (spec.getUsername() != null) {
          connection =
              connectionFactory.createConnection(spec.getUsername(), spec.getPassword());
        } else {
          connection = connectionFactory.createConnection();
        }
        connection.start();
        this.connection = connection;
      } catch (Exception e) {
        throw new IOException("Error connecting to JMS", e);
      }

If start() throws exception, connection should be closed.