[BEAM-1914] XML IO should comply with PTransform style guide

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: sdk-java-core
• Labels: backward-incompatible starter
• Assignee: Eugene Kirpichov
• Reporter: Eugene Kirpichov
• Created: 07/Apr/17 22:09
• Updated: 21/Apr/17 23:57
• Resolved: 19/Apr/17 09:03

Description

Currently we have XmlSource and XmlSink in the Java SDK. They violate the PTransform style guide in several respects:

• They should be grouped into an XmlIO class with read() and write() verbs, like all the other similar connectors
• The source/sink classes should be made private or package-local
• Should get rid of XmlSink.Bound - XmlSink itself should inherit from FileBasedSink
• Could optionally benefit from AutoValue

See e.g. the PR with BigQuery fixes https://github.com/apache/beam/pull/2149

Issue Links

• is part of: BEAM-1353 Beam should comply with PTransform style guide
• links to: GitHub Pull Request #2558