Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-1914

XML IO should comply with PTransform style guide

          Details

            Description

            Currently we have XmlSource and XmlSink in the Java SDK. They violate the PTransform style guide in several respects:

            • They should be grouped into an XmlIO class with read() and write() verbs, like all the other similar connectors
            • The source/sink classes should be made private or package-local
            • Should get rid of XmlSink.Bound - XmlSink itself should inherit from FileBasedSink
            • Could optionally benefit from AutoValue

            See e.g. the PR with BigQuery fixes https://github.com/apache/beam/pull/2149

              Attachments

                Issue Links

                is part of

                Task - A task that needs to be done. BEAM-1353 Beam should comply with PTransform style guide

                • Major - Major loss of function.
                • Closed
                links to

                Web Link GitHub Pull Request #2558

                  Activity

                    People

                    • Assignee:
                      jkff Eugene Kirpichov
                      Reporter:
                      jkff Eugene Kirpichov
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: