Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-1913

TFRecordIO should comply with PTransform style guide

          Details

            Description

            https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java violates a few guidelines from https://beam.apache.org/contribute/ptransform-style-guide/ :

            • Use of Bound and Unbound types: the Read and Write classes themselves should be PTransform's
            • Should have one static entry point per verb - read() and write()
            • Both classes could benefit from AutoValue

            Basically, perform similar surgery like in https://github.com/apache/beam/pull/2149 but on smaller scale since this is a much smaller connector.

              Attachments

                Issue Links

                is part of

                Task - A task that needs to be done. BEAM-1353 Beam should comply with PTransform style guide

                • Major - Major loss of function.
                • Closed
                links to

                Web Link GitHub Pull Request #2559

                  Activity

                    People

                    • Assignee:
                      jkff Eugene Kirpichov
                      Reporter:
                      jkff Eugene Kirpichov
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved: