[BEAM-1913] TFRecordIO should comply with PTransform style guide

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: sdk-java-core
• Labels: backward-incompatible starter
• Assignee: Eugene Kirpichov
• Reporter: Eugene Kirpichov
• Created: 07/Apr/17 22:07
• Updated: 18/Apr/17 21:23
• Resolved: 18/Apr/17 21:23

Description

https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java violates a few guidelines from https://beam.apache.org/contribute/ptransform-style-guide/ :

• Use of Bound and Unbound types: the Read and Write classes themselves should be PTransform's
• Should have one static entry point per verb - read() and write()
• Both classes could benefit from AutoValue

Basically, perform similar surgery like in https://github.com/apache/beam/pull/2149 but on smaller scale since this is a much smaller connector.

Issue Links

• is part of: BEAM-1353 Beam should comply with PTransform style guide
• links to: GitHub Pull Request #2559