[BEAM-191] Remove WindowedValue.valueInEmptyWindows

• Type: Bug
• Status: Resolved
• Priority: P3
• Resolution: Duplicate
• Fix Version/s: Not applicable
• Component/s: sdk-java-core
• Labels: Done windowing
• Assignee: Thomas Groh
• Reporter: Kenneth Knowles
• Created: 13/Apr/16 17:55
• Updated: 06/Oct/20 21:59
• Resolved: 20/Oct/16 18:14

Description

Even though it is acceptable to create a WindowedValue carrying no windows when it is a fully reified WindowedValue<T>, it doesn't really make sense: When it becomes an element in a PCollection that a value must exist within some window.

This has led to some confusion so we should remove the API. It seems there are just 11 files that reference WindowedValue.valueInEmptyWindows [1] that mostly look like they'd be fine with the global window.

[1] https://github.com/apache/incubator-beam/search?p=1&q=valueInEmptyWindows&utf8=%E2%9C%93

Issue Links

• duplicates: BEAM-230 Remove WindowedValue#valueInEmptyWindows
• is duplicated by: BEAM-230 Remove WindowedValue#valueInEmptyWindows
• links to: GitHub Pull Request #316
• links to: GitHub Pull Request #523