[BEAM-1761] Unintended unboxing of potential null pointer in AutoValue_HDFSFileSource

• Type: Bug
• Status: Resolved
• Priority: P3
• Resolution: Not A Problem
• Fix Version/s: Not applicable
• Component/s: io-java-hadoop-file-system
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 20/Mar/17 17:40
• Updated: 16/May/20 13:19
• Resolved: 20/Mar/17 22:54

Description

      if (validateSource == null) {
        missing += " validateSource";
      }
...
      return new AutoValue_HDFSFileSource<T, K, V>(
          this.filepattern,
          this.formatClass,
          this.coder,
          this.inputConverter,
          this.serializableConfiguration,
          this.serializableSplit,
          this.username,
          this.validateSource);

If validateSource is null, it would be unboxed in call to ctor of AutoValue_HDFSFileSource