[BEAM-14546] [Go SDK] passert.Count succeeds for empty PCollections.

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: 2.40.0
• Component/s: sdk-go
• Assignee: Jack McCluskey
• Reporter: Robert Burke
• Created: 01/Jun/22 21:37
• Updated: 03/Jun/22 16:35
• Resolved: 03/Jun/22 16:35

Description

https://github.com/apache/beam/blob/sdks/v2.39.0/sdks/go/pkg/beam/testing/passert/count.go#L28

Since it's using a Combine to do the count, it never executes for empty Pcollections, and is unable to fail.

The fix is: when count > 0, plumb the pcollection through as a side input to a DoFn that requires the side input to be non-empty. This would catch the empty PCollection case.

Issue Links

• links to: GitHub Pull Request #17813