[BEAM-14525] Unable to find Proto getters in certain cases

• Type: Bug
• Status: In Progress
• Priority: P2
• Resolution: Unresolved
• Component/s: extensions-java-protobuf
• Assignee: Unassigned
• Reporter: Balázs Németh
• Created: 27/May/22 01:38
• Updated: 05/Jun/22 00:32

Description

Proto property name: item2partner_id 

Generated java library method names:

• hasItem2PartnerId
• getItem2PartnerId
• setItem2PartnerId
• clearItem2PartnerId

org.apache.beam.sdk.extensions.protobuf.ProtoByteBuddyUtils generated getter name:

• getItem2partnerId

 

Notice the case difference of 'p'. The getter method name creation isn't aligned with protobuf standards.

See:

• https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L246-L248

• https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L173-L208

 

According this logic anything that isn't A-Za-z makes the next character uppercase.

Issue Links

• links to: GitHub Pull Request #17775