[BEAM-14363] Kinesis WatermarkParameters builder clobbers values

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.38.0
• Fix Version/s: 2.39.0
• Component/s: io-java-kinesis
• Labels: aws-sdk-v1 aws-sdk-v2
• Assignee: Nick Caballero
• Reporter: Nick Caballero
• Created: 25/Apr/22 16:15
• Updated: 27/Apr/22 12:39
• Resolved: 27/Apr/22 12:27

Description

The `WatermarkParameters` builder for the Kinesis watermark policy doesn't retain previously set values, which means you can only set either `timestampFn` or `idleDurationThreshold`, but not both.

 

The issue is that the exposed methods call `builder()` instead of `toBuilder()`, losing the previous values.

Issue Links

• links to: GitHub Pull Request #17458