[BEAM-14240] Address Staticcheck Warnings in the Go SDK

• Type: Improvement
• Status: Open
• Priority: P2
• Resolution: Unresolved
• Component/s: sdk-go
• Assignee: Unassigned
• Reporter: Jack McCluskey
• Created: 04/Apr/22 14:18
• Updated: 05/Jun/22 00:13

Description

Clean up warnings from the staticcheck tool in the Go SDK with the aim of eventually enabling staticcheck as a precommit. 

Issue Links

• links to: GitHub Pull Request #17340

Sub-Tasks

• Update error messages in boot.go: Resolved
• Update Go protobuf package to new version: Open
• Add staticcheck to Go Github Actions precommits: Resolved
• Replace use of deprecated strings.Title: Open
• Address Staticcheck warnings in the exec package: Resolved
• Replace use of deprecated ptypes package: Resolved
• Address Staticcheck warnings in the pipelinex package: Resolved
• Address Staticcheck warnings in io packages: Resolved
• Address Staticcheck warnings in the harness package: Resolved
• Address Staticcheck warnings in the graph/coder package: Resolved
• Address Staticcheck warnings in the runners packages: Open
• Address Staticcheck warnings in the reflectx package: Resolved
• Address Staticcheck warnings in the ioutilx package: Resolved
• Address boolean-related staticcheck warnings in the core packages: Resolved
• Exempt fn_test.go from ST1008 check: Triage Needed
• Address staticcheck warnings in the artifact package: Resolved
• Address staticcheck warning in the metrics package: Resolved
• Enable Staticcheck S1021 in Go SDK config: Resolved
• Enable Staticcheck U1000 in Go SDK config: Resolved