[BEAM-13665] Spanner IO request metrics requires projectId within the config when it didn't in the past

• Type: Bug
• Status: Resolved
• Priority: P1
• Resolution: Fixed
• Affects Version/s: 2.34.0, 2.35.0
• Fix Version/s: 2.36.0
• Component/s: io-java-gcp
• Assignee: Niel Markwick
• Reporter: Luke Cwik
• Created: 14/Jan/22 17:45
• Updated: 04/May/22 08:00
• Resolved: 18/Jan/22 22:28

Description

https://github.com/apache/beam/pull/15493 makes the GCP projectID a required parameter - which it was not before, as it could be inferred from the environment - and thus breaks backward compatibility.

Specifically: BatchSpannerRead.java:175 – the toString() is not required on the valueProvider, it should just be a get(), and createServiceCallMetric() in line 195 should handle the situation where projectID could be null

Also SpannerIO.java:1683 has a similar issue with the Write transform.

Issue Links

• Blocked: BEAM-13668 Java Spanner IO Request Count metrics broke backwards compatibility
• is cloned by: BEAM-14405 Java Spanner IO NPE when ProjectID not specified in template executions
• links to: GitHub Pull Request #16547