[BEAM-13599] Overflow in Python Datastore RampupThrottlingFn

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.32.0, 2.33.0, 2.34.0, 2.35.0
• Fix Version/s: 2.36.0
• Component/s: io-py-gcp
• Assignee: Daniel Thevessen
• Reporter: Daniel Thevessen
• Created: 05/Jan/22 00:00
• Updated: 12/Jan/22 18:00
• Resolved: 12/Jan/22 18:00

Description

File "/usr/local/lib/python3.8/site-packages/apache_beam/io/gcp/datastore/v1new/rampup_throttling_fn.py", line 74, in _calc_max_ops_budget
max_ops_budget = int(self._BASE_BUDGET / self._num_workers * (1.5**growth))
RuntimeError: OverflowError: (34, 'Numerical result out of range') `[while running 'Write to Datastore/Enforce throttling during ramp-up-ptransform-483']

An intermediate value is a float dependent on start time, meaning it can run into overflows in long-running pipelines (usually on the ~6th day).

`max_ops_budget` should either clip to float(inf) or INT_MAX, or short-circuit the throttling decision here since it will long be irrelevant by then.

Issue Links

• links to: GitHub Pull Request #16433
• links to: GitHub Pull Request #16462