[BEAM-13563] Generalize AWS client provider to be independent of client type

• Type: Improvement
• Status: Triage Needed
• Priority: P3
• Resolution: Fixed
• Fix Version/s: 2.38.0
• Component/s: io-java-aws
• Labels: aws-sdk-v2
• Assignee: Moritz Mack
• Reporter: Moritz Mack
• Created: 28/Dec/21 11:30
• Updated: 13/Apr/23 11:09
• Resolved: 03/Mar/22 13:51

Description

Currently each AWS IO uses its own client provider, in some cases also separate ones for sync and async clients.

Besides adding lots of boilerplate code across these IOs, this makes it impossible to switch to an async implementation without breaking APIs. 

The approach below would require only one common client provider to build all kinds of clients:

public <BuilderT extends AwsClientBuilder<BuilderT, ClientT>, ClientT> ClientT buildClient(BuilderT builder) {
  if (endpoint != null) {
    builder.endpointOverride(URI.create(endpoint));
  }
  return builder
      .credentialsProvider(credentialsProvider)
      .region(Region.of(region))
      .build();
}

buildClient(DynamoDbClient.builder());
buildClient(DynamoDbAsyncClient.builder());
buildClient(S3Client.builder());
buildClient(S3AsyncClient.builder());
...

Issue Links

• blocks: BEAM-13956 Serialize/deserialize StsClient when serializing/deserializing StsAssumeRoleCredentialsProvider
• fixes: BEAM-13206 Consolidate multiple levels of retries for AWS IOs
• is required by: BEAM-13824 Migrate SnsIO.write to async implementation
• relates to: BEAM-13663 Fix AWS client configuration in AwsModule
• links to: GitHub Pull Request #16657
• links to: GitHub Pull Request #16760